Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7515 - Connection limit problem for "onAccepting" connections. #12320

Merged

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Sep 26, 2024

  • Fixed ManagedSelector.Accept to emit the event "accept failed" when closed.
  • Fixed ConnectionLimit to close connections that exceed the maximum (may happen when the connector is configured with acceptors=0).
  • Added test cases.
  • Added documentation.

* Fixed `ManagedSelector.Accept` to emit the event "accept failed" when closed.
* Fixed `ConnectionLimit` to close connections that exceed the maximum (may happen when the connector is configured with acceptors=0).
* Added test cases.
* Added documentation.

Signed-off-by: Simone Bordet <[email protected]>
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little strange that QTP will close a Closeable task on stop, but doesn't do so on rejected execution.... hmmm probably OK.

@sbordet sbordet merged commit 11476a9 into jetty-12.0.x Sep 27, 2024
10 checks passed
@sbordet sbordet deleted the fix/jetty-12.0.x/7515/improve-connection-limit branch September 27, 2024 16:12
vlsorokin added a commit to vlsorokin/jetty.project that referenced this pull request Oct 9, 2024
…g" connections

* Backport for the PR jetty#12320
  * Fixed `ManagedSelector.Accept` to emit the event "accept failed" when closed.
  * Fixed `ConnectionLimit` to close connections that exceed the maximum (may happen when the connector is configured with acceptors=0).
vlsorokin added a commit to vlsorokin/jetty.project that referenced this pull request Oct 9, 2024
…g" connections

* Backport for the PR jetty#12320
  * Fixed `ManagedSelector.Accept` to emit the event "accept failed" when closed.
  * Fixed `ConnectionLimit` to close connections that exceed the maximum (may happen when the connector is configured with acceptors=0).
vlsorokin added a commit to vlsorokin/jetty.project that referenced this pull request Oct 13, 2024
Signed-off-by: Volodymyr Sorokin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Connection limit problem for "onAccepting" connections
3 participants