Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] SVE-512 tests timeout #1924

Open
SadiinsoSnowfall opened this issue Aug 21, 2024 · 5 comments
Open

[CI] SVE-512 tests timeout #1924

SadiinsoSnowfall opened this issue Aug 21, 2024 · 5 comments
Labels
CI Tasks related to continuous integration **HOT** This is an issue that needs work, like, now

Comments

@SadiinsoSnowfall
Copy link
Collaborator

SadiinsoSnowfall commented Aug 21, 2024

Some tests such as unit.algo.algorithm.min_element_generic_one_pass.exe and unit.algo.algorithm.swap_ranges_generic.exe regularely timeout under SVE-512.

@SadiinsoSnowfall SadiinsoSnowfall added bug Something isn't working CI Tasks related to continuous integration and removed bug Something isn't working labels Aug 21, 2024
@jfalcou jfalcou added the **HOT** This is an issue that needs work, like, now label Aug 27, 2024
@jfalcou
Copy link
Owner

jfalcou commented Sep 7, 2024

I am dropping this old idea back here for discussion.
Instead of compiling tests for cardinal 1 2 4 ... N 2N , what about comiling only for 1 N/2 N N2. It prevents the ballooning with large register ISA.

Currently on AVX512 we test :

  • (1 2 4 8 16) x 3 for 64 bits types
  • (1 2 4 8 16 32 ) x 3 for 32 bits types
  • (1 2 4 8 16 32 64) x 2 for 16 bits types
  • (1 2 4 8 16 32 64 128 ) x 2 for 8 bits types
    For a total of 63 instances of tests

With the other one, it'll be 4 tests per types, for 10 types total, for a grand total of 40. SO a reduction of 36.8% of the number of tests.

@DenisYaroshevskiy
Copy link
Collaborator

  1. Those are algo tests, they try reduced number of types already.

2.I think it's mostly about trying to validate too many things. Those are two_range generic tests. We should look at those and see if we can loop less

@jfalcou
Copy link
Owner

jfalcou commented Sep 7, 2024

Should we then investigate using fuzz8ng firbthe algo test ?

@DenisYaroshevskiy
Copy link
Collaborator

Fuzzing would be amazing. I could spend less time designing horrific contraptions to catch bugs. But you need like somewhere to run those. I doubt oss fuzz will take eve

@jfalcou
Copy link
Owner

jfalcou commented Sep 7, 2024

We can ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Tasks related to continuous integration **HOT** This is an issue that needs work, like, now
Projects
None yet
Development

No branches or pull requests

3 participants