New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insight] Source code should not contain TODO comments #19

Closed

jfelder opened this issue May 12, 2014 · 1 comment

Assignees

Labels

Owner

jfelder commented May 12, 2014

in src/Jfelder/OracleDB/OCI_PDO/OCIStatement.php, line 195

TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    /**
     * Closes the cursor, enabling the statement to be executed again.
     *
     * @return bool Returns TRUE on success or FALSE on failure.
     * @todo Implement function
     */
    public function closeCursor()
    {
        return true;
    }

Posted from SensioLabsInsight

jfelder self-assigned this

jfelder added the enhancement label

Owner Author

jfelder commented May 12, 2014

Removed old comment

jfelder closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment