Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gradle transitive dependency collection #498

Merged
merged 1 commit into from
May 25, 2021
Merged

Improve Gradle transitive dependency collection #498

merged 1 commit into from
May 25, 2021

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented May 24, 2021 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Following #487

@RobiNino RobiNino requested review from eyalbe4 and yahavi May 24, 2021 14:53
yahavi
yahavi approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobiNino RobiNino merged commit 221430e into jfrog:master May 25, 2021
@RobiNino RobiNino deleted the gradle-transitive-impr branch May 25, 2021 08:09
@yahavi yahavi linked an issue May 28, 2021 that may be closed by this pull request
release 4.23.4 of the build-info-extractor-gradle plugin is slow and uses a lot of memory #487
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release 4.23.4 of the build-info-extractor-gradle plugin is slow and uses a lot of memory
2 participants
@RobiNino @yahavi