Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing fields for maven 3.9.0 #706

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix missing fields for maven 3.9.0 #706

merged 3 commits into from
Feb 15, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Feb 15, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Fixes this exception:

[main] ERROR org.apache.maven.cli.MavenCli - NullPointerException
java.lang.NullPointerException
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:296)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:278)
    at org.jfrog.build.extractor.maven.resolver.ArtifactoryEclipseArtifactResolver.resolveArtifacts (ArtifactoryEclipseArtifactResolver.java:56)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact (DefaultArtifactResolver.java:255)

@omerzi omerzi requested review from eyalbe4 and yahavi February 15, 2023 12:29
@omerzi omerzi added bug Create a report to help us improve safe to test Approve running integration tests on a pull request labels Feb 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 15, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Feb 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 15, 2023
@omerzi omerzi changed the title Fix missing dependencies for maven 3.9.0 Fix missing fields for maven 3.9.0 Feb 15, 2023
@omerzi omerzi merged commit c1e4261 into jfrog:master Feb 15, 2023
@yahavi yahavi mentioned this pull request Feb 19, 2023
Closed
@gregoryboue gregoryboue mentioned this pull request Feb 23, 2023
Closed
@yahavi yahavi mentioned this pull request Apr 7, 2023
Closed
@yahavi yahavi mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Create a report to help us improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @yahavi