Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is incompatible with http headers option #43

Closed
jasonschroeder-sfdc opened this issue Oct 12, 2020 · 1 comment · Fixed by #44
Closed

Plugin is incompatible with http headers option #43

jasonschroeder-sfdc opened this issue Oct 12, 2020 · 1 comment · Fixed by #44
Assignees

Comments

@jasonschroeder-sfdc
Copy link
Contributor

https://github.com/jfrog/cocoapods-art/blob/master/lib/cocoapods_plugin.rb is overriding Pod::Downloader::Http, and the contents of this PR are not in the artifactory version. CocoaPods/cocoapods-downloader#89

We have private, published podspecs that use the 'header' key, but when the artifactory plugin is installed, cocoapods crashes.

I see a few options:

  1. copy/paste the changes from Add headers option on Http download strategy CocoaPods/cocoapods-downloader#89 into https://github.com/jfrog/cocoapods-art/blob/master/lib/cocoapods_plugin.rb
  2. Open a PR against https://github.com/CocoaPods/cocoapods-downloader, ask for an extension point to add parameters to curl, get it merged, and then refactor cocoapods-art to use that extension point
@eyalbe4
Copy link
Contributor

eyalbe4 commented Oct 15, 2020

Thank you for reporting this issue @jasonschroeder-sfdc!
We'll be looking into this issue and provide an update here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants