Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin kitchen-sink dependencies do not work as expected #933

Open
jtnord opened this issue May 20, 2024 · 0 comments
Open

plugin kitchen-sink dependencies do not work as expected #933

jtnord opened this issue May 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jtnord
Copy link

jtnord commented May 20, 2024

Describe the bug

the plugin is bundling the kitchen sink inside the plugin's HPI.
Many of these dependencies come from Jenkins core, or are also bundle in non optioanl plugins that this plugin depends on.

in the case the dependency comes from Jenkins core or a non optional dependencies this is just a waste of disk space.

in the case the dependency is also coming from an optional plugin then the plugin may well blow up at runtime, or exhibit different behaviour as the version bundled in the plugin would be used in some installations and not others.

For example the plugin bundles several apache-commons libraries that come from core and are a waste of space.
it also bundles an old version of svnkit that will be used so long as the subversion plugin is not installed, but when it is installed the newer version would be used.

To Reproduce

mvn package -DskipTests
inspect the hpi's WEB-INF\lib directory

Expected behavior

there are no libraries bundled that come from Jenkins core, or non optional dependencies.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Jenkins Artifactory plugin version:
  • Jenkins operating system:
  • Artifactory Version:

Additional context
Add any other context about the problem here.

@jtnord jtnord added the bug Something isn't working label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant