Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support psr/cache v2 #10

Closed
jgivoni opened this issue Jan 17, 2024 · 0 comments · Fixed by #13
Closed

Support psr/cache v2 #10

jgivoni opened this issue Jan 17, 2024 · 0 comments · Fixed by #13
Assignees

Comments

@jgivoni
Copy link
Owner

jgivoni commented Jan 17, 2024

There doesn't seem to be any breaking changes affecting this library between versions 2 and 3 of psr/cache:
https://github.com/php-fig/cache/blob/master/CHANGELOG.md
(The difference is that in v3 "All methods have return types")
So if you're already using psr/cache v2 and cannot upgrade because of this change, this library won't install.
However, if this library already works with psr/cache v2, there's no good reason not to allow it.

  • Verify and test this assumption.
  • Update composer.json like this:
@jgivoni jgivoni self-assigned this Jan 17, 2024
@jgivoni jgivoni linked a pull request Jan 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant