Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page size is not passed on the printing #1893

Open
2 tasks done
FarSeeing opened this issue Oct 21, 2024 · 1 comment
Open
2 tasks done

Page size is not passed on the printing #1893

FarSeeing opened this issue Oct 21, 2024 · 1 comment
Assignees

Comments

@FarSeeing
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug
The pageSize parameter for the .print call was replaces with the preferCSSPageSize one in 40034f6
The issue is that this preferCSSPageSize is supported in printToPDF method only - https://www.electronjs.org/docs/latest/api/web-contents#contentsprintoptions-callback

To Reproduce
Steps to reproduce the behavior:

  1. Set page size to anything but a default A4 one
  2. Print the diagram
  3. The printer settings will get A4 format

Expected behavior
Pass page size to the printer

Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.7.17

Desktop (please complete the following information):

  • OS: Windows, MacOS, Linux...

Additional context
Add any other context about the problem here.

@m-mohamedin
Copy link
Contributor

A fix will be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants