Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Sonar Analyze #531

Closed
pascalgrimaud opened this issue Jan 7, 2020 · 16 comments · Fixed by jhipster/generator-jhipster#12177
Closed

Sonar Analyze #531

pascalgrimaud opened this issue Jan 7, 2020 · 16 comments · Fixed by jhipster/generator-jhipster#12177
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ enhancement New feature or request $100 https://www.jhipster.tech/bug-bounties/

Comments

@pascalgrimaud
Copy link
Member

Current Sonar Analyze for a Vue.js is not so good.
It should be AAA.

I can provide more details if needed.

@pascalgrimaud
Copy link
Member Author

I'm adding a bounty on this as it's important to have it fixed.

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ enhancement New feature or request labels Jan 7, 2020
@atomfrede
Copy link
Member

Is this related to the sonar upstream issues? #431

@pascalgrimaud
Copy link
Member Author

no @atomfrede, I analyze a Vue.js gateway for my customer and there are a lot of issues and bugs
It's easy to fix them, so it can be an easy ticket for a new contributor.
I was asking to @fdaudies : maybe she'll try to fix them :)
Or another new contributor...

@fdaudies
Copy link

fdaudies commented Jan 8, 2020

Thanks @pascalgrimaud , I'll try to work on this issue as a new contributor :)

@hdurix
Copy link
Member

hdurix commented Jan 8, 2020

Don't hesitate to ping us @fdaudies :)

@skmaingi
Copy link
Contributor

skmaingi commented Feb 6, 2020

@pascalgrimaud @fdaudies
Seems like SonarQube doesn't yet support .vue
The problem being that it support single file components (SFC) i.e. Vue files aggregate in one file logic (javascript or typescript), style (css), and template (html).
https://community.sonarsource.com/t/sonarqube-scanner-fails-to-analyze-vue-files-failed-to-parse-file-vue/17751

@pascalgrimaud
Copy link
Member Author

thanks for your comment @skmaingi and you're right !

but what you're talking about is related to this ticket #431 and not to this one :-)

@pascalgrimaud
Copy link
Member Author

It seems like @fdaudies doesn't have the time to do this.
Are you interested on this @skmaingi ? If yes, I'll assign this to you, and I can tell you the steps about the work to do here

@skmaingi
Copy link
Contributor

skmaingi commented Jul 1, 2020

@pascalgrimaud I am interested. Thank you

@pascalgrimaud pascalgrimaud assigned skmaingi and unassigned fdaudies Jul 1, 2020
@pascalgrimaud
Copy link
Member Author

@skmaingi : the steps are:

  • generate a JHipster project with Vue.js
  • start local Sonar instance
  • launch Sonar analyze
  • there is a lot of errors / issues, which can be easily fixed
  • fix them in the generated project
  • relaunch Sonar analyze
  • then, report the appropriate change in blueprint Vue.js

@skmaingi
Copy link
Contributor

skmaingi commented Jul 1, 2020

@pascalgrimaud Thank you for the information. I'll work on it

@pascalgrimaud
Copy link
Member Author

As no news from you, I unassigned the ticket

@qmonmert
Copy link
Contributor

@pascalgrimaud I take this ticket

@pascalgrimaud
Copy link
Member Author

Thanks a lot @qmonmert : I need this :)

@qmonmert
Copy link
Contributor

@qmonmert
Copy link
Contributor

qmonmert commented Jul 30, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ enhancement New feature or request $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants