Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ViT-L-14@336px" model name doesn't work with CLIPTorchEncoder. #799

Closed
delgermurun opened this issue Aug 9, 2022 · 2 comments · Fixed by #803
Closed

"ViT-L-14@336px" model name doesn't work with CLIPTorchEncoder. #799

delgermurun opened this issue Aug 9, 2022 · 2 comments · Fixed by #803

Comments

@delgermurun
Copy link

ViT-L-14@336px model name mentioned in the docs, but it doesn't work anymore.

    uses: jinahub+docker://CLIPTorchEncoder/latest-gpu
    uses_with:
      name: ViT-L-14@336px

But ViT-L-14-336::openai works.

    uses: jinahub+docker://CLIPTorchEncoder/latest-gpu
    uses_with:
      name: ViT-L-14-336::openai
@ZiniuYu
Copy link
Member

ZiniuYu commented Aug 10, 2022

Hi @delgermurun , it is a naming convention. We used to only support OpenAI models and they called it ViT-L/14@336px (left slash). After we switch to OpenCLIP models, we changed to ViT-L-14-336::openai. We kept the old names for backward compatibility. But I do think we need to clarify this or have higher fault tolerance on those names. Thanks for pointing this out!

@delgermurun
Copy link
Author

below image is from https://hub.jina.ai/executor/gzpbl8jh

Screenshot 2022-08-10 at 07 42 58

here even old name is wrong.

@ZiniuYu ZiniuYu linked a pull request Aug 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants