Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from ruamel.yaml to PyYAML before 1.0 release #1471

Closed
hanxiao opened this issue Dec 16, 2020 · 1 comment · Fixed by #1495
Closed

Migrating from ruamel.yaml to PyYAML before 1.0 release #1471

hanxiao opened this issue Dec 16, 2020 · 1 comment · Fixed by #1495
Assignees
Labels
type/feature-request This issue describes a new feature or behaviour a user or users desires.

Comments

@hanxiao
Copy link
Member

hanxiao commented Dec 16, 2020

Describe the feature

For histororical reason, ruamel.yaml was used, it was one of the best YAML python parser by the time 2017. Unfortunately, I recently have growing concerns over its long-term support and may affect Jina:

  • The author of ruamel.yaml moved the project codebase from Github to Gitlab and now to SourceForge. Making it challenge to track the issues and discuss the problems.
  • So far ruamel.yaml does not seem to support Python 3.9, but Jina has 3.9 support in the roadmap (add Python 3.9 support #1253). PyYAML already add 3.9 wheels and working on Python 3.10 nightly!
  • Lower usage compare to PyYAML : daily download at 111,561 vs. PyYAML daily download 1,278,847

In general, it is not about popularity, performance or technology. Yaml parsing is one of the five core depencies to Jina. Extremely extremely important, we need a project that is sustainable enough in the long run, with a robust and open govenenance mode. PyYAML seems to be better on that direction.

Your proposal

Replace ruamel.yaml to PyYAML before 1.0. It must be done before 1.0. I will lead on this.


Environment

Screenshots

@hanxiao hanxiao added the type/feature-request This issue describes a new feature or behaviour a user or users desires. label Dec 16, 2020
@hanxiao hanxiao self-assigned this Dec 16, 2020
@hanxiao
Copy link
Member Author

hanxiao commented Dec 19, 2020

Compatability issues:

@hanxiao hanxiao linked a pull request Dec 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request This issue describes a new feature or behaviour a user or users desires.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant