Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

Unable to download the CRX file #2

Closed
stewartlord opened this issue Jun 21, 2017 · 6 comments
Closed

Unable to download the CRX file #2

stewartlord opened this issue Jun 21, 2017 · 6 comments

Comments

@stewartlord
Copy link

The finalURL is not composed correctly on Mac. Maybe util.format() behaves differently on Mac, but the result is definitely not what you want. I suspect it has to do with the % encoded characters. Simple string concatenation works

@jiripospisil
Copy link
Owner

Huh, could you post the URL of the extension?

@stewartlord
Copy link
Author

Sure!
https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen
This worked fine on Linux, but on Mac the URL was mangled.

@jiripospisil
Copy link
Owner

I don't think it has anything to do with the platform but rather the Node.js version. I can download the extension just fine with Node.js 7.9 but it indeed fails with 8.1.2. What version are you running? Nevertheless, I will look into it more over the weekend.

@stewartlord
Copy link
Author

stewartlord commented Jun 23, 2017

That makes sense. I am running 8.1.0 (on my mac). Thanks!

@jiripospisil
Copy link
Owner

It works again with Node.js 8.1.3. I think it was fixed by nodejs/node#13674. Thank you for the bug report!

@stewartlord
Copy link
Author

Thanks for following-up @jiripospisil 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants