-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add an editor to the image #217
Comments
Hi @DvagNic I think there was a security recommendation not to include editors in production ready images. Is there any way to get easy access to those volumes? Sorry, I've never used Docker for Mac, so I don't know offhand 😄 |
@DvagNic a few options to consider. Caveat that I'm not on Mac, so the first two of these I'm less sure of given your initial report. Edit the files directlyYou can directly edit the relevant configuration files from outside the running Docker images. For example, to modify Use another docker image to obtain vimIf it's significant to you that the files be edited from within a running Docker image, you can do that too, and without needing to modify the base images. Use
You could add such a configuration to the images in this project's Fork and modify jordan/icinga2 base imageIf you needed to be able to deploy a version of this with vim pre-installed, that's possible from a Docker image which extends jordan2/icinga2 Docker image. Something like,
Publish that image somewhere (eg DockerHub), then consume it from a modified Hope that helps! |
Since config files have to be edited inside the container, it would be nice if the image would include vim or another editor. I know that if one uses volumes, one can edit the files on the host, but for Docker on the Mac the volumes are located inside a "hidden" VM and it is not that easy to reach that VM. Editing from within the container makes life easier :)
The text was updated successfully, but these errors were encountered: