Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependence on syntex_syntax causes breakage as of nightly-2019-11-09. #173

Closed
pnkfelix opened this issue Jan 30, 2020 · 5 comments
Closed

Comments

@pnkfelix
Copy link

Here is the output from trying to build on the currently nightly.

% cargo +nightly-2019-11-09 build
[...]
   Compiling syntex_syntax v0.58.1
   Compiling syntect v2.1.0
error[E0423]: expected function, tuple struct or tuple variant, found struct `ast::Name`
   --> /Users/felixklock/.cargo/registry/src/github.com-1ecc6299db9ec823/syntex_syntax-0.58.1/src/symbol.rs:146:27
    |
146 |                       name: ast::Name($index),
    |                             ^^^^^^^^^
...
165 | / declare_keywords! {
166 | |     // Invalid identifier
167 | |     (0,  Invalid,        "")
168 | |
...   |
231 | |     (56, CrateRoot, "{{root}}")
232 | | }
    | |_- in this macro invocation

   Compiling scribe v0.7.2
error: aborting due to previous error

For more information about this error, try `rustc --explain E0423`.
error: could not compile `syntex_syntax`.

To learn more, run the command again with --verbose.
%

This is known fallout from rust-lang/rust#65785 (comment)

@jmacdonald
Copy link
Owner

Thanks for the heads up, @pnkfelix! Hopefully there's another crate I can use as a replacement. 🤞

@pnkfelix
Copy link
Author

pnkfelix commented Feb 3, 2020

Thanks for the heads up, @pnkfelix! Hopefully there's another crate I can use as a replacement. 🤞

Hey @jmacdonald : I asked alexcrichton about this last week, and they told me that you should probably switch to https://crates.io/crates/syn

(So I figure use that, or throw away the build script and figure out how to redo your use case as a proc-macro.)

@jp-pulga
Copy link

jp-pulga commented Feb 4, 2020

Any news on this?

@jmacdonald
Copy link
Owner

jmacdonald commented Feb 4, 2020 via email

@jmacdonald
Copy link
Owner

@pnkfelix for my use case, leaning on file names and a simple regex was enough to extract what I was after. Thanks again! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants