From 766f68aac5c1795e328e2a6e5a8c86345bb5c94b Mon Sep 17 00:00:00 2001
From: Lauser Nicolai <7676540+Maaiins@users.noreply.github.com>
Date: Sun, 8 Mar 2020 00:39:33 +0100
Subject: [PATCH] Bugfix: Visitor history avatar not displayed when
 visitor_avatar_id not set (#458)

* Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended.

* Revert "Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended."

This reverts commit b6bd0e5f

* Bugfix: Visitor history avatar not displayed when visitor_avatar_id not set. Always respond with 404, because url always gets '(not set)' prepended.
---
 modules/base/templates/report_visitor.tpl | 2 +-
 owa_template.php                          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/base/templates/report_visitor.tpl b/modules/base/templates/report_visitor.tpl
index 988518d0f..d24248da6 100644
--- a/modules/base/templates/report_visitor.tpl
+++ b/modules/base/templates/report_visitor.tpl
@@ -1,6 +1,6 @@
 <div>
 	<div style="display: table-cell; vertical-align: middle">
-		<span><img class="owa_avatar" style="vertical-align:middle;" src="<?php echo $this->getAvatarImage( $this->out($this->get('visitor_avatar_id') ) );?>" /></span>
+		<span><img class="owa_avatar" style="vertical-align:middle;" src="<?php $this->out( $this->getAvatarImage( $this->get('visitor_avatar_id') ) );?>" /></span>
 		<span class="inline_h2"><?php $this->out( $visitor_label );?></span>
 	</div>
 	<BR>
diff --git a/owa_template.php b/owa_template.php
index fcc3daf6a..a529f59f9 100755
--- a/owa_template.php
+++ b/owa_template.php
@@ -901,7 +901,7 @@ function formatNumber($num, $decimal_places) {
 	
 	function getAvatarImage($email) {
 		
-		if (false != $email) {
+		if (false != $email && $email !== '(not set)') {
 			$url = sprintf("https://www.gravatar.com/avatar/%s?s=30", md5($email));
 		} else {
 			$url = $this->makeImageLink('base/i/default_user_50x50.png');