Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serializable as an optional/configurable option #404

Closed
samskiter opened this issue Aug 20, 2015 · 5 comments
Closed

Add serializable as an optional/configurable option #404

samskiter opened this issue Aug 20, 2015 · 5 comments
Milestone

Comments

@samskiter
Copy link
Collaborator

Hi, it would be great to be able to mark all my POJOs as serializable. I saw you used to have this feature by default, but removed it (for good reason). In my case, I know that all my POJOs are serializable but don't want to have to mark them all up in the JSON schema. The experimental Parcelable feature isn't working for me either...

Could you maybe add a serializable option to generation? If you prefer, a javaInterfaces option that applies to all POJOs, on top of what they ask for in the schema would be great, but the nice thing about serializable being separate is you could potentially also generate the serialVersionID...

Thanks!

Sam

@joelittlejohn
Copy link
Owner

Sounds like a good, simple config option to add. Happy to accept a PR for this.

Not sure what we should do about generating a serialVersionID (whether to make this random, and different each run, or try to do something more clever). For your use-case, do you care?

@samskiter
Copy link
Collaborator Author

Nope, dont care. maybe worth looking what intelliJ does (i think its a random generation)

@samskiter
Copy link
Collaborator Author

Working on it here: https://github.com/samskiter/jsonschema2pojo (might submit a pr early, so it's easy to see the diff while working on it)

@ctrimble
Copy link
Collaborator

Related to #405

@joelittlejohn joelittlejohn changed the title Re-add serializable as an optional/configurable option Add serializable as an optional/configurable option Apr 11, 2016
@joelittlejohn joelittlejohn added this to the 0.4.23 milestone Apr 11, 2016
@joelittlejohn
Copy link
Owner

Fixed by #549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants