Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructors are incompatible with extends keyword #555

Closed
samskiter opened this issue Apr 25, 2016 · 1 comment
Closed

Constructors are incompatible with extends keyword #555

samskiter opened this issue Apr 25, 2016 · 1 comment
Milestone

Comments

@samskiter
Copy link
Collaborator

If schema A extends schema B and schema A has properties X,Y and Z and schema B has properties L,M and N and includeConstructors is set to true, the constructor of B correctly has arguments for L, M and N but the constructor of A only has arguments for X,Y and Z.

I would expect A to have LMNXYZ in its constructor.

Looking at the code, this looks non-trivial to fix.

@joelittlejohn
Copy link
Owner

Closed by #558

@joelittlejohn joelittlejohn added this to the 0.4.24 milestone May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants