-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org.jsonschema2pojo.ContentResolverTest require internet connection #704
Comments
Hi. Could you explain what you mean by:
? |
Yes you're right about this unit test, it's a little lazy. We could use https://github.com/rest-driver/rest-driver to avoid external http calls. |
@joelittlejohn WireMock has a nice JUnit rule for mocking out http endpoints. |
Well, the "rest-driver" is an overkill for such simple test. And about the '-DforkMode=never' - I'm working behind a proxy & firewall and it damn uncomfortable to configure proxy settings in JVM and they are flashed when tests performed in a forked process... |
The 'WireMock' is really nice! Many thanks for the link. |
Fixed by #705. |
This unit test is not an integratoinal test. Also a special setting like '-DforkMode=never' required for maven-surefire-plugin when it runs behind firewall. Will be better to start a simple local HTTP-server for such tests
The text was updated successfully, but these errors were encountered: