Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.jsonschema2pojo.ContentResolverTest require internet connection #704

Closed
s13o opened this issue Mar 16, 2017 · 6 comments
Closed

org.jsonschema2pojo.ContentResolverTest require internet connection #704

s13o opened this issue Mar 16, 2017 · 6 comments
Milestone

Comments

@s13o
Copy link
Contributor

s13o commented Mar 16, 2017

This unit test is not an integratoinal test. Also a special setting like '-DforkMode=never' required for maven-surefire-plugin when it runs behind firewall. Will be better to start a simple local HTTP-server for such tests

@joelittlejohn
Copy link
Owner

Hi. Could you explain what you mean by:

Also a special setting like '-DforkMode=never' required for maven-surefire-plugin when it runs behind firewall.

?

@joelittlejohn
Copy link
Owner

Yes you're right about this unit test, it's a little lazy. We could use https://github.com/rest-driver/rest-driver to avoid external http calls.

@ctrimble
Copy link
Collaborator

@joelittlejohn WireMock has a nice JUnit rule for mocking out http endpoints.

@s13o
Copy link
Contributor Author

s13o commented Mar 17, 2017

Well, the "rest-driver" is an overkill for such simple test.
As I can see the main idea of it is just to test real http connection & exception handling flow.
I did a pull request #705 - please check it, does it appropriative?

And about the '-DforkMode=never' - I'm working behind a proxy & firewall and it damn uncomfortable to configure proxy settings in JVM and they are flashed when tests performed in a forked process...

@s13o
Copy link
Contributor Author

s13o commented Mar 17, 2017

The 'WireMock' is really nice! Many thanks for the link.
But how many http-tests we have? the only one?
We can refactor this test later when we will desire to implement one more

@thachhoang thachhoang added this to the 0.4.32 milestone Mar 21, 2017
@thachhoang
Copy link
Collaborator

Fixed by #705.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants