Add support for failing check on HTTP error responses #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwmale
approved these changes
Aug 29, 2020
Merged
joelwmale
added a commit
that referenced
this pull request
Aug 29, 2020
- Add support for failing check on HTTP error responses (#23) (@AnandChowdhary) - Bump @types/node from 14.6.0 to 14.6.1 (#21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #22 by throwing an error when a server responds with a failing status code.
According to HTTP response status codes on MDN,
400to499are client errors and500to599are server errors. In this PR, the status check is failed when such an HTTP status is responded with.