-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not support Flake8 6+ #12
Comments
Fixed in version 1.2.1, released today. For what it's worth, the Flake8 dependency of Flake8-pyproject was pinned to Flake8 v6 did introduce some breaking changes with the new major version (as it does, and which is why the pin was put in place), but they didn't affect the parsing of |
I don't know why pip's dependency solver didn't work either, we got these failures when it was unpinned: Either way, with the new release and flake8 unconstrained works: Thanks for the quick release! |
Thanks for the feedback, @coretl. Yeah, that's strange. It installed |
I always stated that upper constraints are armed time-bombs. Unless you already know that next version will break, don't add the constraint. How can you know?
Based on my experience most projects survive major version bumps w/o having to change a thing. pinning... is a nuke. |
@ssbarnea Can you explain why the dependency resolution failed in the above case? |
* Fix make version switcher to use the right key Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987 * Add sphinx autobuild * Use PyPA action for PyPI Publish Use the official Python Packaging Authority (PyPA) Action to publish to PyPI * Fix password parameter * Bump black from 22.8.0 to 22.10.0 Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Sanitize ref name for docs version Translate punctuation and unicode in branch names to _ * move requirements assests to lockfiles zip * fix .dockerignore, build options * add check for dirty repo when building wheel * fix dockerignore to not dirty repo * fix Github Release assets spec * Improve tox-direct handling - Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through * Rely on the container less - Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications * Mount ssh & inputrc in mounts list * Moved config to pyproject.toml * add version label to container registry push * Use importlib.metadata to get package version * Make twine check strict * Don't check switcher if not published - pydata-sphinx-theme 0.11 started checking switcher - this meant you couldn't bootstrap a gh-pages build - pydata-sphinx-theme 0.12 put in an option not to check - but we want checking if the file exists - so only check if we can get the json file - and suggest user turns pages on if we can't * Don't use flake8==6 until plugins catch up john-hen/Flake8-pyproject#12 * Remove flake8 constraint Also shrink dep list where intermediate modules are covered by others * Add agreed upon extensions to customizations * Add common-utils to dev container features * Link to condatiners.dev for devcontainer spec * Remove unused matrix from linkcheck CI * Add publish to anaconda step * Remove conda build & publish from CI * Add YAML type stubs * Temporarily disable switcher check * Remove unused import * Delete dockerfile * Fix references to skeleton Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Tom Cobb <[email protected]> Co-authored-by: Garry O'Donnell <garry.o'[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: Giles Knap <[email protected]>
* Fix make version switcher to use the right key Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987 * Add sphinx autobuild * Use PyPA action for PyPI Publish Use the official Python Packaging Authority (PyPA) Action to publish to PyPI * Fix password parameter * Bump black from 22.8.0 to 22.10.0 Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Sanitize ref name for docs version Translate punctuation and unicode in branch names to _ * move requirements assests to lockfiles zip * fix .dockerignore, build options * add check for dirty repo when building wheel * fix dockerignore to not dirty repo * fix Github Release assets spec * Improve tox-direct handling - Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through * Rely on the container less - Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications * Mount ssh & inputrc in mounts list * Moved config to pyproject.toml * add version label to container registry push * Use importlib.metadata to get package version * Make twine check strict * Don't check switcher if not published - pydata-sphinx-theme 0.11 started checking switcher - this meant you couldn't bootstrap a gh-pages build - pydata-sphinx-theme 0.12 put in an option not to check - but we want checking if the file exists - so only check if we can get the json file - and suggest user turns pages on if we can't * Don't use flake8==6 until plugins catch up john-hen/Flake8-pyproject#12 * Remove flake8 constraint Also shrink dep list where intermediate modules are covered by others * Add agreed upon extensions to customizations * Add common-utils to dev container features * Link to condatiners.dev for devcontainer spec * Remove unused matrix from linkcheck CI * Add publish to anaconda step * Remove conda build & publish from CI * Add YAML type stubs * Temporarily disable switcher check * Remove unused import * Delete dockerfile * Fix references to skeleton Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Tom Cobb <[email protected]> Co-authored-by: Garry O'Donnell <garry.o'[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: Giles Knap <[email protected]>
* Squash all into new skeleton base commit * switch org to DiamondLightSource * Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump black from 22.6.0 to 22.8.0 Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.6.0...22.8.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix twine command * obscure the docs cleanup email * Made tox faster with tox-direct * Switch to pydata-theme and split docs There are now developer and user guides. The version switcher is native to the theme so added a script to generate it. * Run sdist install in container workflow This saves another runner starting up just for this * Update CI badges * Update code.yml Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton). * Update .github/workflows/code.yml Co-authored-by: Tom C (DLS) <[email protected]> * Fix make version switcher to use the right key Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987 * Add sphinx autobuild * Use PyPA action for PyPI Publish Use the official Python Packaging Authority (PyPA) Action to publish to PyPI * Fix password parameter * Bump black from 22.8.0 to 22.10.0 Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Sanitize ref name for docs version Translate punctuation and unicode in branch names to _ * move requirements assests to lockfiles zip * fix .dockerignore, build options * add check for dirty repo when building wheel * fix dockerignore to not dirty repo * fix Github Release assets spec * Improve tox-direct handling - Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through * Rely on the container less - Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications * Mount ssh & inputrc in mounts list * Moved config to pyproject.toml * add version label to container registry push * Use importlib.metadata to get package version * Make twine check strict * Don't check switcher if not published - pydata-sphinx-theme 0.11 started checking switcher - this meant you couldn't bootstrap a gh-pages build - pydata-sphinx-theme 0.12 put in an option not to check - but we want checking if the file exists - so only check if we can get the json file - and suggest user turns pages on if we can't * Don't use flake8==6 until plugins catch up john-hen/Flake8-pyproject#12 * Remove flake8 constraint Also shrink dep list where intermediate modules are covered by others * Add agreed upon extensions to customizations * Add common-utils to dev container features * Link to condatiners.dev for devcontainer spec * Remove unused matrix from linkcheck CI * Add publish to anaconda step * Remove conda build & publish from CI * Stop checking switcher in docs build * Bump softprops/action-gh-release from 0.1.14 to 0.1.15 Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 0.1.14 to 0.1.15. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@1e07f43...de2c0eb) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.0 to 3.9.1. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](peaceiris/actions-gh-pages@de7ea6f...64b46b4) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * simplify local container workflow * add how to do pin requirements doc * add local container testing docs * Fix reference to non-existent setup.cfg file * changed to use '[dev]' instead of [dev] in the docs * Removed scheduled job in code.yaml and added keepalive-workflow * Added the link to autogenerate precommit * Made suggested changes * Add explicit dependency on pytest * Made changes * Add python 3.7 support * Include link in dev install tutorial to epics-containers devcontainer page * Improve container build workflow This will test the container before it is pushed to GHCR * Changed coverage parameters * Added vscode settings * Slight changes to the sed command, and ensuring output is utf-8 on windows --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Tom Cobb <[email protected]> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom C (DLS) <[email protected]> Co-authored-by: Garry O'Donnell <garry.o'[email protected]> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: Callum Forrester <[email protected]> Co-authored-by: tizayi <[email protected]> Co-authored-by: AlexWells <[email protected]> Co-authored-by: Eva Lott <[email protected]> Co-authored-by: Joshua Appleby <[email protected]>
* Squash all into new skeleton base commit * switch org to DiamondLightSource * Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump black from 22.6.0 to 22.8.0 Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.6.0...22.8.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix twine command * obscure the docs cleanup email * Made tox faster with tox-direct * Switch to pydata-theme and split docs There are now developer and user guides. The version switcher is native to the theme so added a script to generate it. * Run sdist install in container workflow This saves another runner starting up just for this * Update CI badges * Update code.yml Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton). * Update .github/workflows/code.yml Co-authored-by: Tom C (DLS) <[email protected]> * Fix make version switcher to use the right key Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987 * Add sphinx autobuild * Use PyPA action for PyPI Publish Use the official Python Packaging Authority (PyPA) Action to publish to PyPI * Fix password parameter * Bump black from 22.8.0 to 22.10.0 Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Sanitize ref name for docs version Translate punctuation and unicode in branch names to _ * move requirements assests to lockfiles zip * fix .dockerignore, build options * add check for dirty repo when building wheel * fix dockerignore to not dirty repo * fix Github Release assets spec * Improve tox-direct handling - Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through * Rely on the container less - Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications * Mount ssh & inputrc in mounts list * Moved config to pyproject.toml * add version label to container registry push * Use importlib.metadata to get package version * Make twine check strict * Don't check switcher if not published - pydata-sphinx-theme 0.11 started checking switcher - this meant you couldn't bootstrap a gh-pages build - pydata-sphinx-theme 0.12 put in an option not to check - but we want checking if the file exists - so only check if we can get the json file - and suggest user turns pages on if we can't * Don't use flake8==6 until plugins catch up john-hen/Flake8-pyproject#12 * Remove flake8 constraint Also shrink dep list where intermediate modules are covered by others * Add agreed upon extensions to customizations * Add common-utils to dev container features * Link to condatiners.dev for devcontainer spec * Remove unused matrix from linkcheck CI * Add publish to anaconda step * Remove conda build & publish from CI * Stop checking switcher in docs build * Bump softprops/action-gh-release from 0.1.14 to 0.1.15 Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 0.1.14 to 0.1.15. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@1e07f43...de2c0eb) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.0 to 3.9.1. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](peaceiris/actions-gh-pages@de7ea6f...64b46b4) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * simplify local container workflow * add how to do pin requirements doc * add local container testing docs * Fix reference to non-existent setup.cfg file * changed to use '[dev]' instead of [dev] in the docs * Removed scheduled job in code.yaml and added keepalive-workflow * Added the link to autogenerate precommit * Made suggested changes * Add explicit dependency on pytest * Made changes * Add python 3.7 support * Include link in dev install tutorial to epics-containers devcontainer page * Improve container build workflow This will test the container before it is pushed to GHCR * Changed coverage parameters * Added vscode settings * Slight changes to the sed command, and ensuring output is utf-8 on windows * Remove trailing spaces and rationalise newlines Some tools remove trailing whitespace by default on save, so may as well correct the originals. Ensures every file ends with an empty blank line. Again some tools do this automatically. * Use ruff as a linter as a replacement for flake8/isort * Bump docker/build-push-action from 3 to 5 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump docker/login-action from 2 to 3 Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump docker/metadata-action from 4 to 5 Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump docker/setup-buildx-action from 2 to 3 Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * (#153) Fix docs build by providing default arg * Fixes for latest skeleton --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Tom Cobb <[email protected]> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom C (DLS) <[email protected]> Co-authored-by: Garry O'Donnell <garry.o'[email protected]> Co-authored-by: Giles Knap <[email protected]> Co-authored-by: Callum Forrester <[email protected]> Co-authored-by: tizayi <[email protected]> Co-authored-by: AlexWells <[email protected]> Co-authored-by: Eva Lott <[email protected]> Co-authored-by: Joshua Appleby <[email protected]> Co-authored-by: Tom Willemsen <[email protected]> Co-authored-by: Dominic Oram <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: