Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol "http:" is not supported with https package #21

Open
plambhsa opened this issue Nov 16, 2018 · 3 comments
Open

Protocol "http:" is not supported with https package #21

plambhsa opened this issue Nov 16, 2018 · 3 comments

Comments

@plambhsa
Copy link
Contributor

The http protocol option doesn't work as expected. I think a check needs to be done to see if the passed in protocol is http or https. Then, if it's http, use the Node http package and not the https package.

screenshot 47

@plambhsa
Copy link
Contributor Author

This is important for testing auth servers locally. I'll try and do this work and submit a PR soon.

@DanielRuf
Copy link
Contributor

Hi @plambhsa,

generally this makes not much sense as the http endpoints do not have any certificate.

So res.socket.getPeerCertificate will fail anyways.

In my opinion it makes not much sense to support other protocols than https.

@DanielRuf
Copy link
Contributor

We should close this issue as wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants