-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from PhantomJS to Electron #50
Comments
I'm not, at the moment. Electron is very unstable, and you can't run it truly headless in linux. segment-boneyard/nightmare#224 (comment) That said, if/when electron becomes more stable and if/when they can run headlessly, then people can probably just use segmentio/nightmare. The two api's are very similar. I would be interested in seeing a benchmark on speed between the two. |
It seems that nightmare caters to a different type of user than your repo. For example, they don't have built in jQuery support and it appears they are not willing to support newly generated windows (see segment-boneyard/nightmare#148). I say "not willing" because @reinpk closed this Issue instead of leaving it open. His comment here (segment-boneyard/nightmare#148 (comment)) states that he doesn't believe the feature is currently possible:
But doesn't explain why. And when I wrote a suggestion as to how it might be done (segment-boneyard/nightmare#148 (comment)) I have yet to get a reply:
You are probably right though on the stability. I have used Atom editor which is built on Electron and it has been unstable to say the least. |
@johntitus I'm not sure if you have seen, but segmentio/nightmare has now moved over from PhantomJS to Electron. Is this something that you are considering?
The nightmare README.md claims that it's faster than PhantomJS:
The text was updated successfully, but these errors were encountered: