Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from PhantomJS to Electron #50

Closed
bchr02 opened this issue Sep 28, 2015 · 2 comments
Closed

Switch from PhantomJS to Electron #50

bchr02 opened this issue Sep 28, 2015 · 2 comments

Comments

@bchr02
Copy link

bchr02 commented Sep 28, 2015

@johntitus I'm not sure if you have seen, but segmentio/nightmare has now moved over from PhantomJS to Electron. Is this something that you are considering?

The nightmare README.md claims that it's faster than PhantomJS:

Under the covers it uses Electron, which is similar to PhantomJS but faster and more modern.

@johntitus
Copy link
Owner

I'm not, at the moment. Electron is very unstable, and you can't run it truly headless in linux.

segment-boneyard/nightmare#224 (comment)

That said, if/when electron becomes more stable and if/when they can run headlessly, then people can probably just use segmentio/nightmare. The two api's are very similar.

I would be interested in seeing a benchmark on speed between the two.

@bchr02
Copy link
Author

bchr02 commented Sep 28, 2015

It seems that nightmare caters to a different type of user than your repo. For example, they don't have built in jQuery support and it appears they are not willing to support newly generated windows (see segment-boneyard/nightmare#148). I say "not willing" because @reinpk closed this Issue instead of leaving it open. His comment here (segment-boneyard/nightmare#148 (comment)) states that he doesn't believe the feature is currently possible:

i don't believe this is possible in electron, so i'm going to close this as not possible unfortunately. if you have an example of a popup script would be great to test it out though

But doesn't explain why. And when I wrote a suggestion as to how it might be done (segment-boneyard/nightmare#148 (comment)) I have yet to get a reply:

@reinpk BrowserWindow.getAllWindows() returns an array of all the BrowserWindow object references. Surely this could be used to incorporate some sort of interaction with newly generated windows.

You are probably right though on the stability. I have used Atom editor which is built on Electron and it has been unstable to say the least.

@bchr02 bchr02 closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants