Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownStylerConfiguration Link Color Not Working #232

Closed
1 task done
fralondon83 opened this issue Oct 20, 2020 · 2 comments
Closed
1 task done

DownStylerConfiguration Link Color Not Working #232

fralondon83 opened this issue Oct 20, 2020 · 2 comments

Comments

@fralondon83
Copy link

fralondon83 commented Oct 20, 2020

Please help prevent duplicate issues before submitting a new one:

  • I've searched other open/closed issues for duplicates before opening up this new issue.

Report

What did you do?

I have used your iOS example code to build a custom style but unfortunately the link color is not changing.

I replaced the content of renderDownInWebView with this

let downView = DownTextView(frame: view.bounds)
let down = Down(markdownString: readMeContents)
let styler = DownStyler(configuration: .testConfiguration)
downView.attributedText = try! down.toAttributedString(styler: styler)

and I am using the DownStylerConfiguration testConfiguration from your test suite.

What did you expect to happen?

In the configuration link color is set as

colors.link = .red

so it should show red links

What happened instead?

it does not show as red but as default blue

Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-20 at 18 23 49

Thanks

@johnxnguyen
Copy link
Owner

Hi @RedPlumber , thanks for the report. I can confirm the issue and know the cause. I'll push a fix when I have some time.

@iwasrobbed-ks
Copy link
Collaborator

Closed via #233 ; will release a new version soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants