Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS 10+] Warnings for WebKit signal service and latex.c #94

Closed
1 task done
antonjazz opened this issue Jul 1, 2018 · 5 comments
Closed
1 task done

[iOS 10+] Warnings for WebKit signal service and latex.c #94

antonjazz opened this issue Jul 1, 2018 · 5 comments

Comments

@antonjazz
Copy link

  • I've searched other open/closed issues for duplicates before opening up this new issue.

Report

What did you do?

I've been using Down successfully in an iOS app project (Xcode 9.4.1, build for iOS 10.0+)

What happened?

It runs fine for me (except for issue #93) but receive two unexpected warnings:

  • at build-time latex.c line 185 generates this warning:
    Implicit conversion loses integer precision: ‘size_t’(aka 'unsigned long' to ‘int’

  • at runtime, the app generates the following output several times
    Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service
    Could not signal service com.apple.WebKit.Networking: 113: Could not find specified service
    Down is the only part of my app that is using WebKit, so it must be related to Down.

Any suggestions?

@iwasrobbed
Copy link
Collaborator

As always, I'm happy to accept pull requests from the community. It's always nice to have help when I've already spent a lot of time building this for others ;)

Here's a few clues for you: http://lmgtfy.com/?q=site%3Astackoverflow.com+Could+not+signal+service+com.apple.WebKit.WebContent

I'll be traveling for a while and won't have time to investigate

@iwasrobbed
Copy link
Collaborator

As for Implicit conversion loses integer precision: ‘size_t’(aka 'unsigned long' to ‘int’, it depends on how you're integrating the library. CocoaPods should silence these sorts of warnings since it's within the underlying C library rather than the Swift wrapper

@iwasrobbed iwasrobbed changed the title Two error messages [iOS 10] Warnings for WebKit signal service and latex.c Jul 1, 2018
@iwasrobbed iwasrobbed changed the title [iOS 10] Warnings for WebKit signal service and latex.c [iOS 10+] Warnings for WebKit signal service and latex.c Jul 1, 2018
@antonjazz
Copy link
Author

Thanks, Rob. I am indeed using CocoaPods to integrate Down, so I'm not sure why I'm getting the implicit conversion warnings… but I'll ignore them until there's a reason why I can't.

@phoney
Copy link
Contributor

phoney commented Nov 8, 2018

The loses precision warning is a legitimate warning. I'm sure the code runs fine but there's a type mismatch. Fixing it would be a simple typecast or changing the type of one of the variables. @iwasrobbed is that a change that you'd accept in a PR?

Actually looking at the current version of cmark they've already fixed this warning with a typecast. I can't tell how much effort it would be to update to the latest version of cmark.

@iwasrobbed
Copy link
Collaborator

Going to close this as @phoney updated cmark to v0.28.3 which would fix that warning.

For the WebKit warning, please ensure you're adding DownView to the parent view before loading a markdown string into it (i.e. https://stackoverflow.com/a/44623268/308315)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants