-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vertically centre progressbar section title on baseline #30
Conversation
I'm not completely convinced this is better than the current behavior, but not sure. What is your motivation for centering with respect to only the text? |
The current behavior is not centered in either case, and in investigating a solution found that rather than having all the content centered, because the title is much more ink heavy than the thin progress bar, visually it appeared better. Particularly in the case when you have a section page with a progress bar followed immediately by a sub-section page (i.e. |
progressbar
section titles to match those of simple
progressbar
section titles to match those of simple
I see. You might be right, I'll have to spend some time looking over and comparing the alternatives. I see that you're right about the current version not being centered either, so at least that should be changed to be the case. If someone else have an opinion here, feel free to chime in. I don't have a strong opinion myself. Maybe @samcarter? |
I think the situation here isn't dissimilar than what is described in https://en.wikipedia.org/wiki/Mat_(picture_framing)#Decoration
The progress bar makes the lower part of the frame heavier and thus a perfectly centred title looks off-centre. |
Hm, yes, I tend to agree. Nice reference. But I think it's true, like @jpcirrus suggests, that the fact that the bar is so thin relatively speaking does make this less clear-cut. On the other hand, as you say, geometry and human perception are two different things. On the whole, I'm happy to accept the PR if it just removes removes just the baselineskip on line 285, so that the entire block is centered. At least it would be a minor improvement for you, @jpcirrus. |
progressbar
section titles to match those of simple
Yes, I agree, the section title does look better when centered on its baseline in the normal case. In proposing centering the title to match that of |
@jpcirrus It might be interesting to see how it would look like if the simple title is moved up to match the one with the progress bar. |
@samcarter yes, I had thought about that! Unfortunately, I am really busy today and it will only be this evening when I get a chance to take a look. |
Further to @samcarter's comment, with After, adding In my opinion it looks better raised, especially when projected, and exactly matches the title height when |
Thanks for the comparison! Personally, I prefer the one with the higher title. |
Thanks for the suggestions here. I experimented a bit with this yesterday and it's not immediately clear to me what to do. I think raising the title on the simple looks fine, but I think the most important combination to optimize for is when I guess it would be possible to ignore the subtitle when defining the layout, and adopt the raise you suggested previously (although I think we need I also noticed just now that the alignment of the subtitle is not great for the progressbar template. Also I think the subtitle in the simple template is maybe too close to the title. So there are probably several small improvements that can be made here. |
I have pushed some changes. The current idea I have is to add This feels somewhat hacky, but maybe it's fine? Let me know what you think. |
Oh, I also fixed the alignment of the subsectiontitle on progressbar pages, which was not right (at least not to me) before. |
use a |
Great, thanks! Now It's just a matter of deciding whether it would make more sense to lower everything slightly. The section title is possibly a little too high up now. |
@jolars these changes look really good. Personally, I think the section pages look better with the titles slightly raised, especially when there is a subsection title. In particular, when the progressbar section page titles are raised by |
Good, but are you sure that's what you want with the new change? Everything is raised by some similar amount now since there is a strut that wasn't there before (for the section page that is). I'm attaching an example pdf of section and supages sat the current sate of this pr. |
Yes, but I would get other feedback too. I have been using customised section page templates with the titles raised above the geometric centre after consideration of the above comments from @samcarter, and asking for feedback from colleagues. Also, I am using aspect ratios with less height: 16:9 and 16:10. When projected, especially with a subsection title, the text had appeared to be too low. The amendments I suggested were after taking into account the addition of the |
I see. Hm, I definitely don't want to move it further up. I was even considering lowering it so maybe this is a reasonable compromise. I think I'll merge this PR now, but I would be open for revisiting this later.
…On Fri Nov 22, 2024 at 9:27 AM CET, John Purnell wrote:
Yes, but I would get other feedback too. I have been using customised section page templates with the titles raised above the geometric centre after consideration of the above comments from @samcarter, and asking for feedback from colleagues. Also, I am using aspect ratios with less height: 16:9 and 16:10. When projected, especially with a subsection title, the text had *appeared* to be too low. The amendments I suggested were after taking into account the addition of the `\strut` on the section page.
|
Section pages with
sectionpage=simple
have the section title vertically centered in the frame. But, those withsectionpage=progressbar
(the default) do not. This commit corrects that.