Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parskip setting influences spacing in unwanted ways #9

Closed
jolars opened this issue Mar 4, 2024 · 5 comments · Fixed by #4
Closed

parskip setting influences spacing in unwanted ways #9

jolars opened this issue Mar 4, 2024 · 5 comments · Fixed by #4

Comments

@jolars
Copy link
Owner

jolars commented Mar 4, 2024

\newlength{\moloch@parskip}
\setlength{\moloch@parskip}{0.5em}
\setlength{\parskip}{\moloch@parskip}

These settings affect spacing in ways which I think are unintended and unwanted. For instance, they insert spacing after list environments, which messes with their vertical alignment, and adds spacing between table captions and tables and verbatim environments and paragraphs.

Removing this would have consequences for a lot of presentations, however, since unless the user has used something like \medskip manually, paragraphs will become clumped together. Perhaps there is a better way to accomplish this.

@jolars
Copy link
Owner Author

jolars commented Mar 4, 2024

This is related to josephwright/beamer#512

@samcarter
Copy link

Similar to #7 I think having a parskip in a presentation isn't as useful as it can be in other classes with longer blocks of text.

I understand your concern that this will mean that many presentation will look differently in moloch than in metropolis, but at least the change will mean that the frame content will be more compact and there won't be any risk of text cut off at the bottom.

@jolars
Copy link
Owner Author

jolars commented Mar 4, 2024

I agree that it's not as useful, no, but I would personally have liked to see paragraph spacing in beamer.

But irrespective of that, the parskip change in the package is currently not working optimally and resulting in these rather strange spacing problems. Also, it has no effect inside for instance the block environment, which just makes the setting clunky and the results hard to predict (at least for new users).

So I think I'll remove the parskip setting. Thanks for the input again!

@Enivex
Copy link

Enivex commented Oct 29, 2024

Similar to #7 I think having a parskip in a presentation isn't as useful as it can be in other classes with longer blocks of text.

I understand your concern that this will mean that many presentation will look differently in moloch than in metropolis, but at least the change will mean that the frame content will be more compact and there won't be any risk of text cut off at the bottom.

I strongly disagree with this.

I currently have to manually insert skips because moloch is too compact.

If you're at risk of getting text cut off, then you're putting too much text into your slides.

@jolars
Copy link
Owner Author

jolars commented Oct 29, 2024

Yes, but at least the change doesn't break someone's existing presentation so badly that some content would be lost (get cut off).

Personally I think it's fine that you have to manually insert skips. This aligns with how beamer works by default and how most other themes work too. If there was some way to produce a good implementation of parskip for moloch, then I would not be opposed to having it be an opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants