Using named cookies to get a correct redirect #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 5, 2022 13:54
caco3
reviewed
Dec 6, 2022
| @@ -829,12 +829,6 @@ static esp_err_t delete_post_handler(httpd_req_t *req) | |||
| return ESP_FAIL; | |||
| } | |||
|
|
|||
| if (filename == 'wlan.ini') { | |||
There was a problem hiding this comment.
@Slider0007 What is the reason you reverted this change?
Will you add it again in a separate pull request?
There was a problem hiding this comment.
@caco3: I wasn't involved in this. I assume you mean @parhedberg.
There was a problem hiding this comment.
ah, right, sorry!
=> @parhedberg What is the reason you reverted this change?
Will you add it again in a separate pull request?
For me it looks ok!
There was a problem hiding this comment.
Sorry.. It is me that is struggeling with my branches.. I made a new pull request with only the wlan fix in it...
There was a problem hiding this comment.
No problem!
Thanks for your contribution in #1509 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this will solve the issue in #1425 and #1424 .. This has not been tested extensively, but worked for locally for me when changing the files in SD-card.
Might be something to work on?