Add basic auth filter new #2241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I would also prefer to add at least basic authentication. |
crasu
force-pushed
the
add_basic_auth_filter_new
branch
from
2e2858a to
7179026
Compare
ThomasCr
reviewed
May 6, 2024
| @@ -57,7 +57,6 @@ build_flags = | |||
| ${flags:runtime.build_flags} | |||
| ; ### Sofware options : (can be set in defines.h) | |||
| -D ENABLE_MQTT | |||
| -D ENABLE_INFLUXDB | |||
ThomasCr
reviewed
May 6, 2024
| @@ -157,8 +180,8 @@ int LoadWlanFromFile(std::string fn) | |||
| #endif | |||
| } | |||
|
|
|||
| /* read next line */ | |||
| if (fgets(zw, sizeof(zw), pFile) == NULL) { | |||
| if (fgets(zw, 1024, pFile) == NULL) | |||
There was a problem hiding this comment.
why not sizeof(zw) - sounds better for me....
… not updating the value is a good idea as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just rebased this again to update to the current rolling version.
This is just a kind heads up to let people know there is some option to run ai on the edge with basic authentification. You may close this pr without comment.
Btw: Running this now for several month without issues.