Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#194 Create more Duration/Timestamp adapters with different time units #199

Merged
merged 4 commits into from
Dec 28, 2020
Merged

#194 Create more Duration/Timestamp adapters with different time units #199

merged 4 commits into from
Dec 28, 2020

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Oct 23, 2020 •
edited
Loading

Closes #194

@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #199 (8da145a) into master (771d85e) will increase coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   76.51%   77.21%   +0.70%     
==========================================
  Files          34       35       +1     
  Lines        2035     2098      +63     
==========================================
+ Hits         1557     1620      +63     
  Misses        478      478
Impacted Files Coverage Δ
src/de/impls.rs 78.51% <ø> (ø)
src/lib.rs 75.00% <ø> (ø)
src/ser/impls.rs 98.03% <ø> (ø)
src/utils/duration.rs 88.43% <100.00%> (+0.78%) ⬆️
tests/serde_as_duration.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771d85e...8da145a. Read the comment docs.

@jonasbb
Add more Duration* and Timestamp* adapters with different base units
df2d69c 
The current Duration* and Timestamp* only support full seconds. Other
time units, like milliseconds, microseconds, or nanoseconds, are
sometimes required too.
@jonasbb
Add small test cases for various Duration and Timestamp variants
8d3890a
@jonasbb jonasbb marked this pull request as ready for review December 27, 2020 14:36
@jonasbb
Copy link
Owner Author

jonasbb commented Dec 28, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 28, 2020

Build succeeded:

@bors bors bot merged commit a6228ea into master Dec 28, 2020
@bors bors bot deleted the issue-194 branch December 28, 2020 11:03
@jonasbb jonasbb mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create further Duration and Timestamp adapters which use milli, micro, and nanoseconds
1 participant
@jonasbb