From 16ff535561aa452a78bcfb56a2e644f276af469d Mon Sep 17 00:00:00 2001
From: Ritchie Vink <ritchie46@gmail.com>
Date: Thu, 23 Sep 2021 20:54:41 +0200
Subject: [PATCH] add validity to list_iter bench

---
 benches/iter_list.rs | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/benches/iter_list.rs b/benches/iter_list.rs
index 7e3a0611d22..87869943b85 100644
--- a/benches/iter_list.rs
+++ b/benches/iter_list.rs
@@ -4,6 +4,7 @@ use arrow2::{
     datatypes::DataType,
 };
 
+use arrow2::bitmap::Bitmap;
 use arrow2::buffer::MutableBuffer;
 use criterion::{criterion_group, criterion_main, Criterion};
 use std::iter::FromIterator;
@@ -19,8 +20,17 @@ fn add_benchmark(c: &mut Criterion) {
         let mut offsets = MutableBuffer::from_iter((0..size as i32).step_by(2));
         offsets.push(size as i32);
 
+        let validity = (0..(offsets.len() - 1))
+            .map(|i| i % 4 == 0)
+            .collect::<Bitmap>();
+
         let data_type = ListArray::<i32>::default_datatype(DataType::Int32);
-        let array = ListArray::<i32>::from_data(data_type, offsets.into(), Arc::new(values), None);
+        let array = ListArray::<i32>::from_data(
+            data_type,
+            offsets.into(),
+            Arc::new(values),
+            Some(validity),
+        );
 
         c.bench_function(&format!("list: iter_values 2^{}", log2_size), |b| {
             b.iter(|| {