From 4d0fe7b7ec243925ffc863e9d8e36445c66b6133 Mon Sep 17 00:00:00 2001 From: "Jorge C. Leitao" Date: Mon, 10 Jan 2022 06:23:05 +0000 Subject: [PATCH] Improved bench --- benches/aggregate.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/benches/aggregate.rs b/benches/aggregate.rs index a8b666458fe..d515fff1281 100644 --- a/benches/aggregate.rs +++ b/benches/aggregate.rs @@ -4,12 +4,12 @@ use arrow2::array::*; use arrow2::compute::aggregate::*; use arrow2::util::bench_util::*; -fn bench_sum(arr_a: &PrimitiveArray) { +fn bench_sum(arr_a: &dyn Array) { sum(criterion::black_box(arr_a)).unwrap(); } -fn bench_min(arr_a: &PrimitiveArray) { - min_primitive(criterion::black_box(arr_a)).unwrap(); +fn bench_min(arr_a: &dyn Array) { + min(criterion::black_box(arr_a)).unwrap(); } fn add_benchmark(c: &mut Criterion) { @@ -24,6 +24,15 @@ fn add_benchmark(c: &mut Criterion) { b.iter(|| bench_min(&arr_a)) }); + let arr_a = create_primitive_array::(size, 0.0); + + c.bench_function(&format!("sum 2^{} i32", log2_size), |b| { + b.iter(|| bench_sum(&arr_a)) + }); + c.bench_function(&format!("min 2^{} i32", log2_size), |b| { + b.iter(|| bench_min(&arr_a)) + }); + let arr_a = create_primitive_array::(size, 0.1); c.bench_function(&format!("sum null 2^{} f32", log2_size), |b| {