From 80de3d256668c2c27ed54c0ac99323c85dffc268 Mon Sep 17 00:00:00 2001 From: Sam Kaufman Date: Fri, 5 Aug 2022 16:04:52 -0700 Subject: [PATCH] FileSink now closes the underlying writer. (#1213) --- src/io/parquet/write/sink.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/io/parquet/write/sink.rs b/src/io/parquet/write/sink.rs index 9ba2d4aea90..5086b8e09e2 100644 --- a/src/io/parquet/write/sink.rs +++ b/src/io/parquet/write/sink.rs @@ -1,7 +1,7 @@ use ahash::AHashMap; use std::{pin::Pin, task::Poll}; -use futures::{future::BoxFuture, AsyncWrite, FutureExt, Sink, TryFutureExt}; +use futures::{future::BoxFuture, AsyncWrite, AsyncWriteExt, FutureExt, Sink, TryFutureExt}; use parquet2::metadata::KeyValue; use parquet2::write::FileStreamer; use parquet2::write::WriteOptions as ParquetWriteOptions; @@ -218,6 +218,7 @@ where this.task = Some(Box::pin(async move { writer.end(kv_meta).map_err(Error::from).await?; + writer.into_inner().close().map_err(Error::from).await?; Ok(None) })); this.poll_complete(cx)