From b67e9b446e40974a711cc6a672e831f2ba6b4135 Mon Sep 17 00:00:00 2001 From: Guillaume Balaine Date: Mon, 3 Jan 2022 02:22:02 +0100 Subject: [PATCH] remove as_fixed_size_array which is only useful for decimal --- src/array/fixed_size_binary/mutable.rs | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/array/fixed_size_binary/mutable.rs b/src/array/fixed_size_binary/mutable.rs index a1166492a02..d7b28883c85 100644 --- a/src/array/fixed_size_binary/mutable.rs +++ b/src/array/fixed_size_binary/mutable.rs @@ -162,15 +162,6 @@ impl MutableFixedSizeBinaryArray { validity.shrink_to_fit() } } - - /// Creates an owned [`FixedSizeBinaryArray`] from current data - pub fn as_fixed_size_array(&mut self) -> FixedSizeBinaryArray { - FixedSizeBinaryArray::from_data( - DataType::FixedSizeBinary(self.size), - std::mem::take(&mut self.values).into(), - std::mem::take(&mut self.validity).map(|x| x.into()), - ) - } } /// Accessors @@ -196,11 +187,19 @@ impl MutableArray for MutableFixedSizeBinaryArray { } fn as_box(&mut self) -> Box { - Box::new(self.as_fixed_size_array()) + Box::new(FixedSizeBinaryArray::from_data( + DataType::FixedSizeBinary(self.size), + std::mem::take(&mut self.values).into(), + std::mem::take(&mut self.validity).map(|x| x.into()), + )) } fn as_arc(&mut self) -> Arc { - Arc::new(self.as_fixed_size_array()) + Arc::new(FixedSizeBinaryArray::from_data( + DataType::FixedSizeBinary(self.size), + std::mem::take(&mut self.values).into(), + std::mem::take(&mut self.validity).map(|x| x.into()), + )) } fn data_type(&self) -> &DataType {