From f383506d32404cf20d285cd09c3b42edabbfc512 Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Wed, 29 Jun 2022 13:09:36 +0200 Subject: [PATCH] parquet: Don't take ownership of `Vec` array_to_columns could do with a slice as `Encoding` is `Copy` --- src/io/parquet/write/pages.rs | 6 +++--- src/io/parquet/write/row_group.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/io/parquet/write/pages.rs b/src/io/parquet/write/pages.rs index 28f45a06fd1..64f6da9a0f6 100644 --- a/src/io/parquet/write/pages.rs +++ b/src/io/parquet/write/pages.rs @@ -198,7 +198,7 @@ pub fn array_to_columns + Send + Sync>( array: A, type_: ParquetType, options: WriteOptions, - encoding: Vec, + encoding: &[Encoding], ) -> Result>>> { let array = array.as_ref(); let nested = to_nested(array, &type_)?; @@ -213,9 +213,9 @@ pub fn array_to_columns + Send + Sync>( .iter() .zip(nested.into_iter()) .zip(types.into_iter()) - .zip(encoding.into_iter()) + .zip(encoding.iter()) .map(|(((values, nested), type_), encoding)| { - array_to_pages(*values, type_, nested, options, encoding) + array_to_pages(*values, type_, nested, options, *encoding) }) .collect() } diff --git a/src/io/parquet/write/row_group.rs b/src/io/parquet/write/row_group.rs index b9960b56001..5558bab49e9 100644 --- a/src/io/parquet/write/row_group.rs +++ b/src/io/parquet/write/row_group.rs @@ -36,7 +36,7 @@ pub fn row_group_iter + 'static + Send + Sync>( .zip(fields.into_iter()) .zip(encodings.into_iter()) .flat_map(move |((array, type_), encoding)| { - let encoded_columns = array_to_columns(array, type_, options, encoding).unwrap(); + let encoded_columns = array_to_columns(array, type_, options, &encoding).unwrap(); encoded_columns .into_iter() .map(|encoded_pages| {