You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
There are some implementations of a from method that are not part of the From trait. Those should probably be renamed to something else, because they normal block usage of From.
E.g. I can't write Utf8Array::from(a) where a has type MutableUtf8Array, despite that conversion existing, because the Rust compiler interprets that as me trying to call the concrete from method for a different type. So I am either forced to write <Utf8Array as From>::from(a) or use a temporary variable with .into().
The text was updated successfully, but these errors were encountered:
Given that we name the iterator over Option<&str>iter and the iterator over &striter_values, I think it would be better to rename from_slice to from_slice_values and this from that collides with From::from, from_slice.
So summarizing:
from(&[Option<T>]) -> from_slice(&[Option<T>])
from_slice(&[T]) -> from_slice_values(&[T])
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are some implementations of a
from
method that are not part of theFrom
trait. Those should probably be renamed to something else, because they normal block usage ofFrom
.E.g. I can't write
Utf8Array::from(a)
wherea
has typeMutableUtf8Array
, despite that conversion existing, because the Rust compiler interprets that as me trying to call the concretefrom
method for a different type. So I am either forced to write<Utf8Array as From>::from(a)
or use a temporary variable with.into()
.The text was updated successfully, but these errors were encountered: