Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix FFI import and export of UnionArray #480

Closed
jorgecarleitao opened this issue Sep 30, 2021 · 0 comments · Fixed by #625
Closed

Fix FFI import and export of UnionArray #480

jorgecarleitao opened this issue Sep 30, 2021 · 0 comments · Fixed by #625
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Sep 30, 2021 •
edited
Loading

Follow-up of apache/arrow#11280 : there was a bug in the C++ implementation when exporting and importing the union array that has been propagated to our implementation via integration tests. We should change our import and export to be aligned with the specification.

We MAY offer backward compatibility (e.g. to be able to read from the buggy exports), but this is not required as this implementation is relatively new when compared to C++.

NOTE: surprisingly, this bug and its fix does not result in UB in neither importing from buggy exporters nor buggy importing importing from correct exports.
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 30, 2021
@jorgecarleitao jorgecarleitao mentioned this issue Nov 22, 2021
Merged
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed error in union FFI jorgecarleitao/arrow2
1 participant
@jorgecarleitao