Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allow nested dictionaries in IPC #499

Closed
jorgecarleitao opened this issue Oct 8, 2021 · 1 comment
Closed

Allow nested dictionaries in IPC #499

jorgecarleitao opened this issue Oct 8, 2021 · 1 comment
Labels
enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Oct 8, 2021 •
edited
Loading

Basically, add a new generated_nested_dictionaries test file,

#[test]
fn read_generated_nested_dictionary() -> Result<()> {
    test_file("1.0.0-littleendian", "generated_nested_dictionary")?;
    test_file("1.0.0-bigendian", "generated_nested_dictionary")
}

and make it pass without breaking other tests.

There is also a comment

// TODO: handle nested dictionaries
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Oct 8, 2021
@jorgecarleitao jorgecarleitao mentioned this issue Nov 6, 2021
Closed
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Nov 11, 2021
@jorgecarleitao
Copy link
Owner Author

This has been closed by #587

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgecarleitao