Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Migrate to Dictionary(Box<DataType>, Box<Field>) #501

Closed
jorgecarleitao opened this issue Oct 8, 2021 · 1 comment
Closed

Migrate to Dictionary(Box<DataType>, Box<Field>) #501

jorgecarleitao opened this issue Oct 8, 2021 · 1 comment
Labels
backwards-incompatible good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@jorgecarleitao
Copy link
Owner

This is a requirement to allow complete roundtrips in IPC.

Check the comment

// todo: make DataType::Dictionary hold a Field so that it can hold dictionary_id
@jorgecarleitao jorgecarleitao mentioned this issue Nov 6, 2021
Closed
@jorgecarleitao
Copy link
Owner Author

Not needed as demonstrated by #587

@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backwards-incompatible good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgecarleitao