Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added StreamWriter::into_inner #574

Closed
dimasukr opened this issue Nov 4, 2021 · 3 comments · Fixed by #575
Closed

Added StreamWriter::into_inner #574

dimasukr opened this issue Nov 4, 2021 · 3 comments · Fixed by #575
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@dimasukr
Copy link

dimasukr commented Nov 4, 2021

Writer has into_inner() while StreamWriter lacks it.
I'm evaluating moving to Arrow2 from Arrow and there StreamWriter has it and we use it for tests and microbenchmarks
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Nov 4, 2021
@jorgecarleitao jorgecarleitao mentioned this issue Nov 4, 2021
Merged
@jorgecarleitao jorgecarleitao changed the title Add into_inner to StreamWriter to make it match FileWriter that has it Added StreamWriter::into_inner Nov 4, 2021
@jorgecarleitao
Copy link
Owner

Good catch, thanks! Done at #575.

@dimasukr
Copy link
Author

dimasukr commented Nov 5, 2021

Great thanks
Good that you removed Bufferer as well because in my case Reader is already buffered so nice to have option not to double buffer

@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Nov 5, 2021
@jorgecarleitao
Copy link
Owner

Not sure what is your use-case, but you may also consider using the async version: #577

it currently blocks on serializing the batch to bytes, which is not optional, but it still concurrent on writing over the write ^_^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplified IPC stream writer / remove finish on drop from stream writer jorgecarleitao/arrow2
2 participants
@jorgecarleitao @dimasukr