Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

ser/de for datatype within scope? #766

Closed
houqp opened this issue Jan 14, 2022 · 3 comments · Fixed by #858
Closed

ser/de for datatype within scope? #766

houqp opened this issue Jan 14, 2022 · 3 comments · Fixed by #858
Labels
feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@houqp
Copy link
Collaborator

houqp commented Jan 14, 2022

I noticed Serialize, Deserialize are not derived for datatypes::DataType while working on the roapi port. Is this within scope of arrow2? or should we come up with our own custom implementations downstream instead?
@ritchie46
Copy link
Collaborator

If it does, I think it should be feature flagged as it brings the serde dependency with it.

@houqp
Copy link
Collaborator Author

houqp commented Jan 14, 2022

I agree, should definitely be feature gated if we are to add it to the core.

@jorgecarleitao
Copy link
Owner

I think we should under a gate - serde is so ubiquitous in Rust, and it is such a pain to implement it to a foreign struct xD

@houqp houqp mentioned this issue Feb 22, 2022
Merged
@jorgecarleitao jorgecarleitao added feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog labels Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for datatypes serde houqp/arrow2
3 participants
@houqp @jorgecarleitao @ritchie46