From cf2381554d6539b36e7bf8a663ea1c19348deeb4 Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Tue, 19 Jul 2022 10:16:21 +0200 Subject: [PATCH 1/3] implement Default for Utf8Array --- src/array/utf8/mod.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/array/utf8/mod.rs b/src/array/utf8/mod.rs index 69c5af6e8f0..c4ebbb3e25d 100644 --- a/src/array/utf8/mod.rs +++ b/src/array/utf8/mod.rs @@ -590,3 +590,14 @@ unsafe impl GenericBinaryArray for Utf8Array { self.offsets() } } + +impl Default for Utf8Array { + fn default() -> Self { + let data_type = if O::IS_LARGE { + DataType::LargeUtf8 + } else { + DataType::Utf8 + }; + Utf8Array::new(data_type, Default::default(), Default::default(), None) + } +} From b18e3d8f25159c71a6259d3058f619ceb14c2387 Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Tue, 19 Jul 2022 22:02:03 +0200 Subject: [PATCH 2/3] Update src/array/utf8/mod.rs Co-authored-by: Jorge Leitao --- src/array/utf8/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/array/utf8/mod.rs b/src/array/utf8/mod.rs index c4ebbb3e25d..bfe273be657 100644 --- a/src/array/utf8/mod.rs +++ b/src/array/utf8/mod.rs @@ -598,6 +598,6 @@ impl Default for Utf8Array { } else { DataType::Utf8 }; - Utf8Array::new(data_type, Default::default(), Default::default(), None) + Utf8Array::new(data_type, vec![0].into(), Default::default(), None) } } From 3a631299a30ed6ad4b23680e2ce744c89a89b400 Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Wed, 20 Jul 2022 07:56:52 +0200 Subject: [PATCH 3/3] use Offset trait --- src/array/utf8/mod.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/array/utf8/mod.rs b/src/array/utf8/mod.rs index bfe273be657..67c6c9c3a39 100644 --- a/src/array/utf8/mod.rs +++ b/src/array/utf8/mod.rs @@ -598,6 +598,11 @@ impl Default for Utf8Array { } else { DataType::Utf8 }; - Utf8Array::new(data_type, vec![0].into(), Default::default(), None) + Utf8Array::new( + data_type, + vec![O::from_usize(0).unwrap()].into(), + Default::default(), + None, + ) } }