From c02043e972af07477e360b223bc2024656b2f51f Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Fri, 22 Jul 2022 14:05:33 +0200 Subject: [PATCH 1/2] use FnMut for PrimitiveArray::apply_validity --- src/array/primitive/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/array/primitive/mod.rs b/src/array/primitive/mod.rs index 74604ed7e8b..0cb9bdc88ba 100644 --- a/src/array/primitive/mod.rs +++ b/src/array/primitive/mod.rs @@ -286,7 +286,7 @@ impl PrimitiveArray { /// This is an API to leverage clone-on-write /// # Panics /// This function panics if the function `f` modifies the length of the [`Bitmap`]. - pub fn apply_validity Bitmap>(&mut self, f: F) { + pub fn apply_validity Bitmap>(&mut self, mut f: F) { if let Some(validity) = std::mem::take(&mut self.validity) { self.set_validity(Some(f(validity))) } From 0ff04673ac5804c19209b22eaf2b691cd8f40104 Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Sat, 23 Jul 2022 09:58:31 +0200 Subject: [PATCH 2/2] FnOnce > FnMut --- src/array/primitive/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/array/primitive/mod.rs b/src/array/primitive/mod.rs index 0cb9bdc88ba..85e04de20d8 100644 --- a/src/array/primitive/mod.rs +++ b/src/array/primitive/mod.rs @@ -286,7 +286,7 @@ impl PrimitiveArray { /// This is an API to leverage clone-on-write /// # Panics /// This function panics if the function `f` modifies the length of the [`Bitmap`]. - pub fn apply_validity Bitmap>(&mut self, mut f: F) { + pub fn apply_validity Bitmap>(&mut self, f: F) { if let Some(validity) = std::mem::take(&mut self.validity) { self.set_validity(Some(f(validity))) }