From 7587ab01131802e1d1d737bcc777f95e7ad9787a Mon Sep 17 00:00:00 2001 From: Ritchie Vink Date: Wed, 15 Sep 2021 16:39:12 +0200 Subject: [PATCH 1/3] io_csv -> {io_csv_read, io_csv_write} --- Cargo.toml | 4 +++- src/io/csv/mod.rs | 2 ++ src/io/mod.rs | 2 +- src/util/mod.rs | 4 ++-- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 61256afcd44..029163afaeb 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -94,7 +94,9 @@ full = [ "chrono-tz", ] merge_sort = ["itertools"] -io_csv = ["csv", "lazy_static", "regex", "lexical-core", "streaming-iterator"] +io_csv = ["io_csv_read", "io_csv_write"] +io_csv_read = ["csv", "lazy_static", "regex", "lexical-core"] +io_csv_write = ["csv", "streaming-iterator", "lexical-core"] io_json = ["serde", "serde_json", "indexmap"] io_ipc = ["flatbuffers"] io_ipc_compression = ["lz4", "zstd"] diff --git a/src/io/csv/mod.rs b/src/io/csv/mod.rs index bafc5b4c673..7e6d4faeae4 100644 --- a/src/io/csv/mod.rs +++ b/src/io/csv/mod.rs @@ -16,5 +16,7 @@ impl From for ArrowError { } } +#[cfg(feature = "io_csv_read")] pub mod read; +#[cfg(feature = "io_csv_write")] pub mod write; diff --git a/src/io/mod.rs b/src/io/mod.rs index 94c7a2f471b..1ad0c3b4598 100644 --- a/src/io/mod.rs +++ b/src/io/mod.rs @@ -1,5 +1,5 @@ //! Interact with different formats such as Arrow, CSV, parquet, etc. -#[cfg(feature = "io_csv")] +#[cfg(any(feature = "io_csv_read", feature = "io_csv_write"))] #[cfg_attr(docsrs, doc(cfg(feature = "io_csv")))] pub mod csv; diff --git a/src/util/mod.rs b/src/util/mod.rs index 996134d35a6..b608f96c269 100644 --- a/src/util/mod.rs +++ b/src/util/mod.rs @@ -1,8 +1,8 @@ //! Misc utilities used in different places in the crate. -#[cfg(any(feature = "compute", feature = "io_csv"))] +#[cfg(any(feature = "compute", feature = "io_csv_write", feature = "io_csv_read"))] mod lexical; -#[cfg(any(feature = "compute", feature = "io_csv"))] +#[cfg(any(feature = "compute", feature = "io_csv_write", feature = "io_csv_read"))] pub use lexical::*; #[cfg(feature = "benchmarks")] From a8850df3935b1bd320db3129d2f01caca8cbeb59 Mon Sep 17 00:00:00 2001 From: Jorge Leitao Date: Fri, 17 Sep 2021 05:41:36 +0100 Subject: [PATCH 2/3] Update src/io/csv/mod.rs --- src/io/csv/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/io/csv/mod.rs b/src/io/csv/mod.rs index 7e6d4faeae4..27f4fb9a1c9 100644 --- a/src/io/csv/mod.rs +++ b/src/io/csv/mod.rs @@ -19,4 +19,5 @@ impl From for ArrowError { #[cfg(feature = "io_csv_read")] pub mod read; #[cfg(feature = "io_csv_write")] +#[cfg_attr(docsrs, doc(cfg(feature = "io_csv_write")))] pub mod write; From 90fb4234a362f034d5331d5c5719a9847f79c5f7 Mon Sep 17 00:00:00 2001 From: Jorge Leitao Date: Fri, 17 Sep 2021 05:41:41 +0100 Subject: [PATCH 3/3] Update src/io/csv/mod.rs --- src/io/csv/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/io/csv/mod.rs b/src/io/csv/mod.rs index 27f4fb9a1c9..4fe139c8dea 100644 --- a/src/io/csv/mod.rs +++ b/src/io/csv/mod.rs @@ -17,6 +17,7 @@ impl From for ArrowError { } #[cfg(feature = "io_csv_read")] +#[cfg_attr(docsrs, doc(cfg(feature = "io_csv_read")))] pub mod read; #[cfg(feature = "io_csv_write")] #[cfg_attr(docsrs, doc(cfg(feature = "io_csv_write")))]