From a3c2b4d2bbe44099d47d35a323b60fdd628ed1ac Mon Sep 17 00:00:00 2001 From: yjhmelody <465402634@qq.com> Date: Wed, 13 Oct 2021 12:21:20 +0800 Subject: [PATCH 1/2] export missing BinaryValueIter --- src/array/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/array/mod.rs b/src/array/mod.rs index f13b0a4eb00..dc013873280 100644 --- a/src/array/mod.rs +++ b/src/array/mod.rs @@ -379,7 +379,7 @@ pub mod ord; pub use display::get_display; pub use equal::equal; -pub use binary::{BinaryArray, MutableBinaryArray}; +pub use binary::{BinaryArray, MutableBinaryArray, BinaryValueIter}; pub use boolean::{BooleanArray, MutableBooleanArray}; pub use dictionary::{DictionaryArray, DictionaryKey, MutableDictionaryArray}; pub use fixed_size_binary::{FixedSizeBinaryArray, MutableFixedSizeBinaryArray}; From 9e9ead753676a8cd4e7916fde28b13debc11b84d Mon Sep 17 00:00:00 2001 From: yjhmelody <465402634@qq.com> Date: Wed, 13 Oct 2021 14:00:24 +0800 Subject: [PATCH 2/2] fix --- src/array/binary/iterator.rs | 1 + src/array/mod.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/array/binary/iterator.rs b/src/array/binary/iterator.rs index 9da47daba21..8a96cc400e5 100644 --- a/src/array/binary/iterator.rs +++ b/src/array/binary/iterator.rs @@ -14,6 +14,7 @@ pub struct BinaryValueIter<'a, O: Offset> { } impl<'a, O: Offset> BinaryValueIter<'a, O> { + /// Creates a new [`BinaryValueIter`] pub fn new(array: &'a BinaryArray) -> Self { Self { array, index: 0 } } diff --git a/src/array/mod.rs b/src/array/mod.rs index dc013873280..52469577ee7 100644 --- a/src/array/mod.rs +++ b/src/array/mod.rs @@ -379,7 +379,7 @@ pub mod ord; pub use display::get_display; pub use equal::equal; -pub use binary::{BinaryArray, MutableBinaryArray, BinaryValueIter}; +pub use binary::{BinaryArray, BinaryValueIter, MutableBinaryArray}; pub use boolean::{BooleanArray, MutableBooleanArray}; pub use dictionary::{DictionaryArray, DictionaryKey, MutableDictionaryArray}; pub use fixed_size_binary::{FixedSizeBinaryArray, MutableFixedSizeBinaryArray};