Fix gradualizer_int:int_type_to_range/1 crash #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Aug 24, 2022
erszcz
force-pushed
the
int-type-to-range-crash
branch
from
718e542
to
c7e8a11
Compare
zuiderkwast
reviewed
Aug 24, 2022
Comment on lines
8
to
10
| %% Caused a crash in int_type_to_range/1 on {var, _, 'A'}. | ||
| %% It's now fixed by assuming that a type var means any integer whatsoever. | ||
| foo() -> -id(42). |
There was a problem hiding this comment.
Well, the type variable can also be instantiated to any() or float(). What we assume is that it's a type that if an integer is included, its negation is also included, or sth like that.... We should perhaps add some constraints on the negated variable, but I don't know how that would look like or how it could work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438 by assuming that a type var is any number. It should probably also generate a constraint on the type var, but there's no path for returning constraints from
gradualizer_intyet, so we might need to revisit this module anyway once there's a constraint solver in place.