Housekeeping #453
Merged
Housekeeping #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maps have better printing support in the VM and therefore make traces significantly more compact. I didn't go for sets v2, since they're only available since OTP 24.0. Rudimentary maps are available for way longer, so we should be more backward compatible with this choice.
Before this create_env() could not pick up some type definitions if they were preceded by comments.
erszcz
force-pushed
the
housekeeping
branch
from
5690689 to
9605a03
Compare
zuiderkwast
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some housekeeping on top of #452 which does not change functionality, but refactors some things to facilitate troubleshooting. I think it's best to review #452 first and, once everything seems fine there, only get to this one.