Fix map type inference #457
Conversation
See josefs#432 for some context.
| @@ -3,11 +3,19 @@ | |||
| -compile([nowarn_unused_function]). | |||
| -export([not_good/1]). | |||
|
|
|||
| -spec good(#{ good := A }) -> A. | |||
| good(#{ good := X }) -> X. | |||
| -gradualizer([infer]). | |||
There was a problem hiding this comment.
The test suite is a little disorganized wrt infer. But I think it would be helpful to have separate files for things which are tested with infer enabled and have infer in the name.
There was a problem hiding this comment.
Good point, I'll split out the parts relying on infer.
| not_good(M). | ||
|
|
||
| -spec kaboom2() -> integer(). | ||
| kaboom2() -> |
There was a problem hiding this comment.
The test machinery makes use of the number of exported functions and compares it to the number of failures per test suite. The idea is that all the 'should fail' functions should be exported.
There was a problem hiding this comment.
I'm aware of the mechanism using exports. The thing is this was failing when it was broken - with the fix, it doesn't anymore. Another reason to split out the test into a corresponding should_pass test.
The example comes from josefs#378.
…ariant_map_keys_fail.erl
erszcz
force-pushed
the
fix-map-type-inference
branch
from
30f3b71
to
8fe9691
Compare
This fixes #432 and fixes #378.