Skip to content

Commit

Permalink
winVersion unittests/operator check: test with 'Windows 8' instead of…
Browse files Browse the repository at this point in the history
… getWinVer when checking operators. Re nvaccess#11837.

An important reminder from Reef Turner (NV Access): make unit tests system-independent i.e. do not use winVersion.getWinVer function when testing operators. Instead, test 'Windows 8' a.k.a. first version to support audio ducking.
  • Loading branch information
josephsl committed Dec 8, 2020
1 parent 3bd9ba2 commit c3d41f9
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/unit/test_winVersion.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ def test_moreRecentWinVer(self):
minor=1,
build=7601
)
audioDuckingAvailable = winVersion.WinVersion(
major=6,
minor=2,
build=9200
)
self.assertGreaterEqual(
winVersion.getWinVer(), minimumWinVer
audioDuckingAvailable, minimumWinVer
)

def test_isWin10(self):
Expand Down

0 comments on commit c3d41f9

Please sign in to comment.