Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser doesn't handle actions #12

Closed
dwmintz opened this issue Jul 25, 2019 · 2 comments
Closed

Parser doesn't handle actions #12

dwmintz opened this issue Jul 25, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@dwmintz
Copy link

dwmintz commented Jul 25, 2019

Doesn't look like the tests cover the action param and the parser choked on ones in my schema

https://docs.looker.com/reference/field-params/action

I can grab the error it was throwing if that's helpful

@joshtemple
Copy link
Owner

joshtemple commented Jul 25, 2019

I'm guessing you're getting a KeyError about action already existing in the tree? And you have multiple action declarations in your LookML?

Looks like I was using an outdated documentation reference for all of the field possibilities so lkml didn't know that action and some of its child fields can appear multiple times.

This is an easy fix, I'll add it to 0.1.2 which I should be able to release in a week or so.

@joshtemple joshtemple added this to the 0.1.2 milestone Jul 25, 2019
@dwmintz
Copy link
Author

dwmintz commented Jul 25, 2019

Sounds right. Yes, there were multiple actions on the field

@joshtemple joshtemple mentioned this issue Jul 26, 2019
@joshtemple joshtemple added the bug Something isn't working label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants